Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PageStorage APIs support throw_on_not_exist. #4736

Merged
merged 7 commits into from
May 5, 2022
Merged

PageStorage APIs support throw_on_not_exist. #4736

merged 7 commits into from
May 5, 2022

Conversation

jiaqizho
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #3594

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 22, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CalvinNeo
  • JaySon-Huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 22, 2022
@jiaqizho
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 22, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PageStorage.h                      27                 8    70.37%          27                 8    70.37%          84                22    73.81%           0                 0         -
V2/PageStorage.cpp                530               152    71.32%          36                 3    91.67%         898               176    80.40%         358               149    58.38%
V2/PageStorage.h                   49                10    79.59%          20                 3    85.00%          48                 3    93.75%          22                10    54.55%
V3/PageDirectory.cpp              507                81    84.02%          31                 2    93.55%        1077               194    81.99%         396                96    75.76%
V3/PageDirectory.h                 25                 5    80.00%          25                 5    80.00%         104                16    84.62%           0                 0         -
V3/PageStorageImpl.cpp            119                43    63.87%          21                 7    66.67%         245                75    69.39%          64                37    42.19%
V3/PageStorageImpl.h                6                 2    66.67%           6                 2    66.67%           6                 2    66.67%           0                 0         -
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                            1263               301    76.17%         166                30    81.93%        2462               488    80.18%         840               292    65.24%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17250      9408             45.46%    194299  95797        50.70%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 22, 2022
@jiaqizho jiaqizho changed the title [WIP]Add a param into PageStorage read. PageStorage APIs support throw_on_not_exist. Apr 24, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 24, 2022
@jiaqizho jiaqizho mentioned this pull request Apr 27, 2022
Merged
12 tasks
JaySon-Huang
JaySon-Huang reviewed Apr 28, 2022
View reviewed changes
dbms/src/Storages/Page/V2/PageFile.cpp Outdated Show resolved Hide resolved
dbms/src/Storages/Page/PageStorage.h Show resolved Hide resolved
dbms/src/Storages/Page/V3/PageStorageImpl.cpp Outdated Show resolved Hide resolved
dbms/src/Storages/Page/V3/tests/gtest_page_storage.cpp Outdated Show resolved Hide resolved
@jiaqizho
Copy link
Contributor Author

@JaySon-Huang @lidezhu @flowbehappy PTAL

JaySon-Huang
JaySon-Huang approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 29, 2022
CalvinNeo
CalvinNeo approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 5, 2022
@jiaqizho
Copy link
Contributor Author

jiaqizho commented May 5, 2022

/merge

@ti-chi-bot
Copy link
Member

@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4506e7a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 5, 2022
@ti-chi-bot
Copy link
Member

@jiaqizho: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented May 5, 2022

Coverage for changed files

Filename                                          Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Page.h                                                 54                 5    90.74%          13                 0   100.00%          59                 7    88.14%          34                12    64.71%
PageDefines.h                                           8                 2    75.00%           8                 2    75.00%          14                 4    71.43%           0                 0         -
PageStorage.h                                          28                 9    67.86%          28                 9    67.86%          87                25    71.26%           0                 0         -
V1/PageStorage.cpp                                    389               306    21.34%          23                13    43.48%         656               471    28.20%         290               229    21.03%
V1/PageStorage.h                                       10                 8    20.00%          10                 8    20.00%          10                 8    20.00%           0                 0         -
V2/PageFile.cpp                                       576               211    63.37%          57                 5    91.23%        1064               291    72.65%         390               159    59.23%
V2/PageFile.h                                          70                15    78.57%          31                 2    93.55%          92                27    70.65%          40                19    52.50%
V2/PageStorage.cpp                                    549               169    69.22%          38                 5    86.84%         941               218    76.83%         368               158    57.07%
V2/PageStorage.h                                       49                10    79.59%          20                 3    85.00%          48                 3    93.75%          22                10    54.55%
V2/tests/gtest_page_storage_multi_writers.cpp         427               427     0.00%          22                22     0.00%         192               192     0.00%          94                94     0.00%
V3/PageDirectory.cpp                                  514                79    84.63%          31                 2    93.55%        1096               191    82.57%         400                94    76.50%
V3/PageDirectory.h                                     25                 4    84.00%          25                 4    84.00%         104                13    87.50%           0                 0         -
V3/PageEntry.h                                         17                 2    88.24%           5                 0   100.00%          29                 8    72.41%           8                 2    75.00%
V3/PageStorageImpl.cpp                                127                31    75.59%          23                 7    69.57%         293                68    76.79%          70                26    62.86%
V3/PageStorageImpl.h                                    6                 2    66.67%           6                 2    66.67%           6                 2    66.67%           0                 0         -
V3/tests/entries_helper.h                              65                36    44.62%          10                 3    70.00%         240               112    53.33%          32                21    34.38%
V3/tests/gtest_page_storage.cpp                      2962              1059    64.25%          35                 7    80.00%         803               154    80.82%         938               553    41.04%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                5876              2375    59.58%         385                94    75.58%        5734              1794    68.71%        2686              1377    48.73%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17261      9410             45.48%    194522  95862        50.72%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented May 5, 2022

Coverage for changed files

Filename                                          Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Page.h                                                 54                 5    90.74%          13                 0   100.00%          59                 7    88.14%          34                12    64.71%
PageDefines.h                                           8                 2    75.00%           8                 2    75.00%          14                 4    71.43%           0                 0         -
PageStorage.h                                          29                 9    68.97%          29                 9    68.97%         108                25    76.85%           0                 0         -
V1/PageStorage.cpp                                    389               306    21.34%          23                13    43.48%         656               471    28.20%         290               229    21.03%
V1/PageStorage.h                                       10                 8    20.00%          10                 8    20.00%          10                 8    20.00%           0                 0         -
V2/PageFile.cpp                                       576               211    63.37%          57                 5    91.23%        1064               291    72.65%         390               159    59.23%
V2/PageFile.h                                          70                15    78.57%          31                 2    93.55%          92                27    70.65%          40                19    52.50%
V2/PageStorage.cpp                                    549               169    69.22%          38                 5    86.84%         941               218    76.83%         368               158    57.07%
V2/PageStorage.h                                       49                10    79.59%          20                 3    85.00%          48                 3    93.75%          22                10    54.55%
V2/tests/gtest_page_storage_multi_writers.cpp         427               427     0.00%          22                22     0.00%         192               192     0.00%          94                94     0.00%
V3/PageDirectory.cpp                                  514                79    84.63%          31                 2    93.55%        1096               191    82.57%         400                94    76.50%
V3/PageDirectory.h                                     25                 4    84.00%          25                 4    84.00%         104                13    87.50%           0                 0         -
V3/PageEntry.h                                         17                 2    88.24%           5                 0   100.00%          29                 8    72.41%           8                 2    75.00%
V3/PageStorageImpl.cpp                                136                32    76.47%          23                 7    69.57%         294                68    76.87%          74                28    62.16%
V3/PageStorageImpl.h                                    8                 2    75.00%           8                 2    75.00%          21                 2    90.48%           0                 0         -
V3/tests/entries_helper.h                              65                36    44.62%          10                 3    70.00%         240               112    53.33%          32                21    34.38%
V3/tests/gtest_page_storage.cpp                      2962              1059    64.25%          35                 7    80.00%         803               154    80.82%         938               553    41.04%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                5888              2376    59.65%         388                94    75.77%        5771              1794    68.91%        2690              1379    48.74%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18073      10150            43.84%    200495  101018       49.62%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit e59b63e into pingcap:master May 5, 2022
@jiaqizho jiaqizho deleted the ps-add-interface branch May 5, 2022 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalvinNeo CalvinNeo CalvinNeo approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@lidezhu lidezhu Awaiting requested review from lidezhu

@flowbehappy flowbehappy Awaiting requested review from flowbehappy

@hehechen hehechen Awaiting requested review from hehechen

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jiaqizho @ti-chi-bot @sre-bot @JaySon-Huang @CalvinNeo